[FIX] hr_gamification: solve runbot error about record assignment#4949
Open
Faruk372742 wants to merge 1 commit intomaster-hr-onboarding-faavcfrom
Open
[FIX] hr_gamification: solve runbot error about record assignment#4949Faruk372742 wants to merge 1 commit intomaster-hr-onboarding-faavcfrom
Faruk372742 wants to merge 1 commit intomaster-hr-onboarding-faavcfrom
Conversation
|
This PR targets the un-managed branch odoo-dev/odoo:master-hr-onboarding-faavc, it needs to be retargeted before it can be merged. |
arpi-odoo
requested changes
Jan 12, 2026
arpi-odoo
left a comment
arpi-odoo
left a comment
There was a problem hiding this comment.
The commit message and PR description is not correct
Comment on lines
29
to
32
| # employee.goal_ids = self.env['gamification.goal'].search([ | ||
| # ('user_id', '=', employee.user_id.id), | ||
| # ('challenge_id.challenge_category', '=', 'hr'), | ||
| # ]) |
Faruk372742
force-pushed
the
master-hr-onboarding-appraisal_goals_make_m2o_v2-faavc
branch
from
52e3ca1 to
25135f2
Compare
Bug production steps: It shows an error in the runbot build Bug cause: self.env['gamification.goal'].search returns goal ids in an array [ids], but assigning this array to directly employee.goals_ids is giving error because it is O2M field. Bug solution: Assigning in the proper format ([(6, 0, goals.ids)]) instead of just assigning goals.ids. task - 5473086
Faruk372742
force-pushed
the
master-hr-onboarding-appraisal_goals_make_m2o_v2-faavc
branch
from
25135f2 to
5c24f18
Compare
Faruk372742
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.